Fix handling of a disconnect with multiple connections #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Oh that is AWESOME! |
|
🎉 This PR is included in version 0.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue and a fix for a problem with handling a connection disconnecting when multiple connections are involved.
To reproduce the issue, run a simple Bleno process with
DEBUG=*:ignoring event because handle is unknown to bleno.disconnectevent being triggeredThis issue could also lead to congestion problems within
pushAclOutQueue(), sincethis._handleAclsInProgress[handle]will not be cleared. It seems to be simply a leftover from when Bleno only supported a single connection at a time.Borrowed the
this._handleAclsInProgress[handle] === undefinedcheck from the handling of theEVT_NUMBER_OF_COMPLETED_PACKETSevent.Happy to discuss or change anything you like!