Skip to content

Conversation

@eonicum
Copy link

@eonicum eonicum commented Nov 11, 2025

No description provided.

@stoprocent
Copy link
Owner

Thanks for taking the time to submit this PR! However, I can't merge it in its current state. There are a couple of issues that need to be addressed:

  1. Commented code: Please remove all commented-out code sections
  2. Cross-platform impact: The changes modify noble's core behavior in ways that affect all platforms, not just macOS. We need a solution that either isolates the fix to macOS or doesn't break functionality on other platforms

I'm definitely open to merging a fix for this issue, but it needs to meet our code quality standards and not introduce regressions elsewhere. Would you be able to revise the PR to address these points? Happy to discuss the approach if you'd like to chat about the best way forward.

@eonicum
Copy link
Author

eonicum commented Nov 12, 2025

Sorry for the confusion with the PR.

I just wanted to show what works for this issue. I should’ve made it clearer in the PR that this is only a proof of concept, not production-ready code (I mentioned it here #23 (comment), but not in the PR, sorry).

Unfortunately, I don’t have much time till the end of the year to work on a proper fix, but I’m happy to help with testing or answer any questions if you need. Thanks for understanding!

@eonicum eonicum force-pushed the fixup/macos-reconnect-after-wake branch from 1ffce1e to b783ba8 Compare November 20, 2025 17:25
@eonicum eonicum force-pushed the fixup/macos-reconnect-after-wake branch from b783ba8 to 42c4d6d Compare November 20, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants