Skip to content

fix(noble): disconnect event type and error handling #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stoprocent merged 1 commit into from
Dec 4, 2025
Merged

fix(noble): disconnect event type and error handling #55

stoprocent merged 1 commit into from
Dec 4, 2025

Conversation

@liamcmitchell
Copy link

@liamcmitchell liamcmitchell commented Nov 21, 2025 •
edited
Loading

  • disconnect event emits a reason string (or undefined), not an error
  • Mac & Win bindings don't emit a reason, so default to "unknown"
  • reject an actual error on disconnect, not a string/undefined

@stoprocent stoprocent self-requested a review December 4, 2025 10:02
@stoprocent stoprocent merged commit a61d7bc into stoprocent:main Dec 4, 2025
15 checks passed
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

🎉 This PR is included in version 2.3.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stoprocent stoprocent stoprocent approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liamcmitchell @stoprocent