Add the shardSplitThreshold option to this library #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added shardSplitThreshold to the car pack index
added shardSplitThreshold
vasco-santos
requested changes
Sep 20, 2021
Member
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
Thanks for the PR @obo20
Left some inline suggestions to fix the linting job
| maxChildrenPerNode: maxChildrenPerNode || unixfsImporterOptionsDefault.maxChildrenPerNode, | ||
| wrapWithDirectory: wrapWithDirectory === false ? false : unixfsImporterOptionsDefault.wrapWithDirectory | ||
| wrapWithDirectory: wrapWithDirectory === false ? false : unixfsImporterOptionsDefault.wrapWithDirectory, | ||
| ...(shardSplitThreshold) && { shardSplitThreshold : shardSplitThreshold } |
Member
There was a problem hiding this comment.
tslint job is failing here with:
src/pack/index.ts:24:31
ERROR: 43:37 object-literal-shorthand Expected property shorthand in object literal ('{shardSplitThreshold}').
Suggested change
| ...(shardSplitThreshold) && { shardSplitThreshold : shardSplitThreshold } | |
| ...(shardSplitThreshold) && { shardSplitThreshold } |
| maxChildrenPerNode: maxChildrenPerNode || unixfsImporterOptionsDefault.maxChildrenPerNode, | ||
| wrapWithDirectory: wrapWithDirectory === false ? false : unixfsImporterOptionsDefault.wrapWithDirectory | ||
| wrapWithDirectory: wrapWithDirectory === false ? false : unixfsImporterOptionsDefault.wrapWithDirectory, | ||
| ...(shardSplitThreshold) && { shardSplitThreshold : shardSplitThreshold } |
Member
There was a problem hiding this comment.
Suggested change
| ...(shardSplitThreshold) && { shardSplitThreshold : shardSplitThreshold } | |
| ...(shardSplitThreshold) && { shardSplitThreshold } |
| wrapWithDirectory?: boolean, | ||
| hasher?: MultihashHasher | ||
| hasher?: MultihashHasher, | ||
| shardSplitThreshold?: number |
Member
There was a problem hiding this comment.
linter failing here with:
src/pack/index.ts:24:31
ERROR: 24:31 no-trailing-whitespace trailing whitespace
Suggested change
| shardSplitThreshold?: number | |
| shardSplitThreshold?: number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the shardSplitThreshold option to be passed in to js-ipfs-unixfs