(Windows) added fix to preserve embedded nulls within text data

[spacepope]

Hi,
as stated in the docs this plugin has this known issue on Windows:

Truncation issue with UNICODE \u0000 character (same as \0)

I ran into this issue using PouchDB with SQLite Adapter in an Cordova/Ionic App and noticed, that in a Windows UWP App index databases generated by PouchDB were not successfully filled. After digging deeper into the PouchDB source code i saw that index document id's are generated by concatenating multiple values as strings with \u0000 as separator.

Because the current implementation of ColumnText and BindText are using automatic string length estimation (which means looking for the first null char), the data text gets truncated and is not fully written/read.

On my search i stumbled upon a bug report on Web SQL implementation of Chromium, which addresses exactly this issue.
So i did nearly the same patch on ColumnText and pass the string length calculated from the number of text bytes reported by SQLite into the string constructor.

Looking a bit deeper into the SQLite3 docs i saw also the description of the third parameter of sqlite3_bind_text16(), which could be set to the number of bytes the string has.
So for BindText i did the opposite of the fix above and pass the number of bytes calculated from the string length.

This seems to work and the index id column is updated and fetched with embedded nulls (SQLiteBrowser reports this as a BLOB and doesn't show a string representation any more, but the binary data are exactly as expected..)

As i am not that C++ guy, i am a bit concerned, whether the string length or byte count calculation is always correct, regardless of things like encoding, etc..
So can you please double check this on testing my PR?

Thanks so far, i hope we can fix this issue with my PR and prevent others from running into these problems..

[spacepope]

Hmm, i don't see why travis builds are failing..
But it seems like this is not an issue with the code itself but the travis configuration?

[brody4hire]

Thanks @spacepope for the nice contribution, my apologies for the delay. The changes definitely look OK to me. The Windows platform version with your changes will pass u0000 character tests in the test suite. I hope to integrate in an upcoming minor release (#685), otherwise will be part of the next major release (#687).

P.S. No worries about the Travis build, will probably be removed.

[spacepope]

Glad that i could help.
So maybe next time i get a humongous discount for the commercial license 😉 😃

[brody4hire]

@spacepope I would definitely be happy to give you a discount with credit for your work on the next commercial license, will discuss by email whenever you are ready. Thanks again for your contributions.