Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/v8 #538

Merged
merged 149 commits into from
Sep 22, 2024
Merged

feat/v8 #538

merged 149 commits into from
Sep 22, 2024

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Jan 21, 2024

  • updated to be compatible with v8
  • new ui
  • ui components extracted to ui package
  • better hmr (story list updates live without reloads)

breaking:

  • new requirements
    • @gorhom/bottom-sheet, react-native-gesture-handler, react-native-reanimated, react-native-svg

todo:

  • new controls ui
  • currently on rn cli a react-native-url-polyfill is needed to not crash the app, need to track this down and fix
  • rework the bottom sheet
  • make the new ui work on web/wide screens
  • refactor theme, right now its a mix between old and new (copy of web theme). Instead should update anywhere that references old theme values to use new theme values.

progress:

progress4apr.mp4

@dannyhw
Copy link
Member Author

dannyhw commented Sep 15, 2024

New alpha version 8.3.0-alpha.0out with simplfied theme and updated controls ui to (kind of) match web style
npx create-expo-app --template expo-template-storybook@next sbv8alpha

If you have a custom theme then sorry it probably breaks but with the new ui I wanted to reuse the web theme to make it easier to update in the future.

@dannyhw
Copy link
Member Author

dannyhw commented Sep 15, 2024

8.3.0-alpha.1 fixes rncli compatibility by applying the polyfill automatically if URLSearchParams.get is not available

Have it working in my example project here:

dannyhw/react-native-storybook-starter#7

@dannyhw
Copy link
Member Author

dannyhw commented Sep 15, 2024

Ok added a basic widescreen ui and made sure each addon is working on web. Don't expect anything fancy but it at least works.

(you can use react storybook with addon-react-native-web to get the full storybook web experience)

image

@dannyhw
Copy link
Member Author

dannyhw commented Sep 16, 2024

8.3.0-alpha.2 is out with more fixes and all the other changes

expo template on next tag also updated
npx create-expo-app --template expo-template-storybook@next sbv8alpha

@dannyhw dannyhw marked this pull request as ready for review September 20, 2024 06:56
@dannyhw dannyhw self-assigned this Sep 21, 2024
* V8 using theme data

* Update Notes.tsx

* fix: conditional hook and code block styles

---------

Co-authored-by: Daniel Williams <[email protected]>
@dannyhw dannyhw merged commit 6e03789 into next Sep 22, 2024
1 check passed
@dannyhw dannyhw deleted the feat/v8 branch September 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants