-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue: fix vue-component-meta
docgen HMR not working
#29518
base: next
Are you sure you want to change the base?
Vue: fix vue-component-meta
docgen HMR not working
#29518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
async handleHotUpdate({ file, read, server, modules, timestamp }) { | ||
const content = await read(); | ||
checker.updateFile(file, content); | ||
// Invalidate modules manually | ||
const invalidatedModules = new Set<ModuleNode>(); | ||
|
||
for (const mod of modules) { | ||
server.moduleGraph.invalidateModule(mod, invalidatedModules, timestamp, true); | ||
} | ||
|
||
server.ws.send({ type: 'full-reload' }); | ||
return []; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider using more granular HMR updates instead of full page reload. A full reload works but may impact development experience for large applications.
fc67014
to
9b9889d
Compare
9b9889d
to
b9ac9dd
Compare
@larsrickert What do you think about this? |
Closes #27514
What I did
Currently, the
vue-component-meta
plugin is only running when Storybook is initially launched, but it never updates afterwards. The only way to get the updated values inside Storybook is to stop the dev server and relaunch it everytime there is a change, which is a far from ideal DX experience.This PR proposes two steps (each in a separate commit) to improve the current experience :
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn task --task sandbox --start-from auto --template vue3-vite/default-ts
.storybook/main.ts
to use thevue-component-meta
plugin for docgen:Button
storyButton.vue
component to change the generated meta, for example with a new prop:Button
story has been updated correctly, for example with the addedwithBorder
prop:Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Enhanced HMR functionality for Vue component metadata in Storybook by adding support for dynamic updates without requiring server restarts.
handleHotUpdate
hook incode/frameworks/vue3-vite/src/plugins/vue-component-meta.ts
to update component metadata on file changes