-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add Preact-vite framework docs #30271
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
|
||
### In a project without Storybook | ||
|
||
Follow the prompts after running this command in your React project's root directory: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: 'React project' should be 'Preact project' since this is Preact-specific documentation
* 🪄 Zero config | ||
* 💫 and more! | ||
|
||
<If notRenderer="Preact"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Case mismatch in notRenderer="Preact" - should be lowercase 'preact' to match renderer="preact" usage below
```js filename=".storybook/main.js" renderer="react" language="js" | ||
export default { | ||
// ... | ||
// framework: '@storybook/preact-webpack5', 👈 Remove this | ||
framework: '@storybook/preact-vite', // 👈 Add this | ||
}; | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: renderer should be 'preact' instead of 'react' since this is Preact-specific documentation
```ts filename=".storybook/main.ts" renderer="react" language="ts" | ||
import { StorybookConfig } from '@storybook/preact-vite'; | ||
|
||
const config: StorybookConfig = { | ||
// ... | ||
// framework: '@storybook/preact-webpack5', 👈 Remove this | ||
framework: '@storybook/preact-vite', // 👈 Add this | ||
}; | ||
|
||
export default config; | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: renderer should be 'preact' instead of 'react' since this is Preact-specific documentation
View your CI Pipeline Execution ↗ for commit d88c49b.
☁️ Nx Cloud last updated this comment at |
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>