Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make CheckBox styling respect the figma design #1806

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rami-pro
Copy link

@rami-pro rami-pro commented Nov 4, 2024

What does it do?

I just added styling to my checkbox styeled component, and changed icon's color based on the state of the checkbox if it's disabled or not

Why is it needed?

refer issue : strapi/strapi#22032

How to test it?

Check on the storybook and compare to figma design at link

Related issue(s)/PR(s)

strapi/strapi#22032

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 5577038

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 3:22pm

@hanpaine
Copy link
Contributor

hanpaine commented Nov 4, 2024

Hey @rami-pro nice catch 🚀 we'll take a look as soon as possible 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants