Add contextual error #132
Open
Add contextual error #132
+1,682
−1,005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@plebhash I’ve adapted the pool according to what we discussed. Let me know what you think. I’ll handle the JDC and Tproxy updates next in this PR. |
plebhash
reviewed
Dec 12, 2025
Shourya742
force-pushed
the
2025-12-12-add-contextual-error
branch
from
0c2036e to
a898fa1
Compare
Member
looks good to me |
plebhash
approved these changes
Dec 16, 2025
Shourya742
force-pushed
the
2025-12-12-add-contextual-error
branch
2 times, most recently
from
90d442c to
31504fc
Compare
GitGab19
reviewed
Dec 18, 2025
Member
GitGab19
left a comment
GitGab19
left a comment
There was a problem hiding this comment.
I just started the review, but I prefer to have some replies from you before proceeding with the rest, to be sure I got the idea behind the Source introduced here.
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
Contributor
|
Started a testing session with the changes of this PR. |
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
Shourya742
force-pushed
the
2025-12-12-add-contextual-error
branch
2 times, most recently
from
579ae19 to
7446ef0
Compare
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/extensions_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/jd_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/jd_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/jd_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/jd_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/jd_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
miner-apps/jd-client/src/lib/channel_manager/upstream_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Dec 23, 2025
GitGab19
reviewed
Jan 6, 2026
GitGab19
reviewed
Jan 6, 2026
GitGab19
reviewed
Jan 6, 2026
GitGab19
reviewed
Jan 6, 2026
GitGab19
reviewed
Jan 6, 2026
GitGab19
reviewed
Jan 6, 2026
Contributor
Author
|
This is the policy I am following here: for internal errors, we shut down directly, for non-internal errors, we disconnect or fall back as appropriate. I am still not entirely sure about the correct behavior when we are opening a channel and something goes wrong while creating the channel snapshot. For now, I am disconnecting the affected downstream, but this could also reasonably be treated as an internal error. Curious to hear what others think. |
plebhash
reviewed
Jan 7, 2026
miner-apps/jd-client/src/lib/downstream/common_message_handler.rs
Outdated
Show resolved
Hide resolved
Shourya742
force-pushed
the
2025-12-12-add-contextual-error
branch
from
05c4386 to
72ff644
Compare
This was referenced Jan 8, 2026
Shourya742
force-pushed
the
2025-12-12-add-contextual-error
branch
from
72ff644 to
f476065
Compare
GitGab19
reviewed
Jan 9, 2026
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs
Show resolved
Hide resolved
GitGab19
reviewed
Jan 9, 2026
miner-apps/jd-client/src/lib/channel_manager/upstream_message_handler.rs
Outdated
Show resolved
Hide resolved
miner-apps/jd-client/src/lib/channel_manager/upstream_message_handler.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+454
to
+455
| messages_results | ||
| .push(Err(JDCError::disconnect(e, *downstream_id))); |
Member
There was a problem hiding this comment.
Shouldn't this be shutdown?
It seems an internal error
Comment on lines
43
to
45
| return Err(JDCError::fallback( | ||
| JDCErrorKind::UpstreamMessageDuringSoloMining, | ||
| )); |
Member
There was a problem hiding this comment.
What happens if we fallback while we're already doing SOLO mining?
Contributor
Author
There was a problem hiding this comment.
This gonna never happen, if it does, we just disconnect from the upstream entity. Should I just remove this?
Contributor
Author
There was a problem hiding this comment.
JDC sets up its mode based on SetupConnection.Success flag which is wrong, fix it.
GitGab19
reviewed
Jan 9, 2026
GitGab19
reviewed
Jan 9, 2026
GitGab19
reviewed
Jan 9, 2026
miner-apps/translator/src/lib/sv2/channel_manager/channel_manager.rs
Outdated
Show resolved
Hide resolved
miner-apps/translator/src/lib/sv2/channel_manager/channel_manager.rs
Outdated
Show resolved
Hide resolved
miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs
Outdated
Show resolved
Hide resolved
GitGab19
reviewed
Jan 9, 2026
pool-apps/pool/src/lib/channel_manager/mining_message_handler.rs
Outdated
Show resolved
Hide resolved
pool-apps/pool/src/lib/channel_manager/mining_message_handler.rs
Outdated
Show resolved
Hide resolved
pool-apps/pool/src/lib/channel_manager/mining_message_handler.rs
Outdated
Show resolved
Hide resolved
pool-apps/pool/src/lib/channel_manager/mining_message_handler.rs
Outdated
Show resolved
Hide resolved
pool-apps/pool/src/lib/channel_manager/mining_message_handler.rs
Outdated
Show resolved
Hide resolved
pool-apps/pool/src/lib/channel_manager/mining_message_handler.rs
Outdated
Show resolved
Hide resolved
pool-apps/pool/src/lib/channel_manager/mining_message_handler.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I closed earlier PR by mistake and removed all the commits: #86.