Skip to content

Conversation

@Shourya742
Copy link
Collaborator

@Shourya742 Shourya742 commented Jan 1, 2026

Part of #37

This PR adapt translator with new context changes to sv1 traits.

companion to stratum-mining/stratum#2047

@plebhash
Copy link
Member

plebhash commented Jan 2, 2026

from the discussions on Discord over the past few days, I was under the impression that this would help mitigate the deadlock issues that were recently identified

but on this PR, I see that we're only adapting tProxy to the API changes introduced by stratum-mining/stratum#2047

are we planning to fix the deadlock on a follow up?

@plebhash
Copy link
Member

plebhash commented Jan 2, 2026

@Shourya742 I think you need to update miner-apps/Cargo.lock to unblock CI here

@Shourya742
Copy link
Collaborator Author

from the discussions on Discord over the past few days, I was under the impression that this would help mitigate the deadlock issues that were recently identified

but on this PR, I see that we're only adapting tProxy to the API changes introduced by stratum-mining/stratum#2047

are we planning to fix the deadlock on a follow up?

Yes, because that's a deeper refactor.

@plebhash plebhash force-pushed the 2026-01-01-adapt-to-new-sv1-handler branch from 055f631 to 08b4b72 Compare January 4, 2026 18:50
@plebhash
Copy link
Member

plebhash commented Jan 4, 2026

@Shourya742 I think you need to update miner-apps/Cargo.lock to unblock CI here

force-pushed this so I can merge and rebase #156

@plebhash plebhash force-pushed the 2026-01-01-adapt-to-new-sv1-handler branch 2 times, most recently from e0e28af to 0506a34 Compare January 4, 2026 18:58
@plebhash plebhash force-pushed the 2026-01-01-adapt-to-new-sv1-handler branch from 0506a34 to 04f89ab Compare January 4, 2026 19:06
@plebhash plebhash merged commit f080061 into stratum-mining:main Jan 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants