-
Couldn't load subscription status.
- Fork 40
[WIP] clarify new_shares_sum field of SubmitShares.Success
#126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] clarify new_shares_sum field of SubmitShares.Success
#126
Conversation
new_shares_sum field of SubmitShares.Success
87d8db6 to
8a56281
Compare
|
Thanks for adding these graphics, it makes things way easier to understand! |
9f44b3b to
592112a
Compare
…o belong to Group Channels
…ong to Group Channels
it's not clear what the `new_shares_sum` field of `SubmitShares.Success` really means after reaching out to @jakubtrnka , he described the following: > `new_submits_accepted_count` is number of submits. > `new_shares_sum` is "integral" over difficulty of work to be confirmed by this success msg this commit clarifies both `SubmitShares.Success` and `SubmitShares.Error` with detailed descriptions and new visual diagrams.
|
note: I should take the opportunity of this PR to also clarify this: the description of currently, when SRI sends a
|
|
with regards to the comment above, I confirmed that SRI is currently incorrect that should be fixed via stratum-mining/stratum#1968 |
…f `SubmitShares.Success`
592112a to
ce15cb7
Compare
close #125
Markdown rendering of my fork