allow Group Channels to contain Extended Channels #162
+19
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o belong to Group Channels
…ong to Group Channels
GitGab19
reviewed
Oct 29, 2025
|
|
||
| Prevhash is distributed whenever a new block is detected in the network by an upstream node or when a new downstream opens a channel. | ||
|
|
||
| This message MAY be shared by all downstream nodes (sent only once to each channel group). |
There was a problem hiding this comment.
Suggested change
| This message MAY be shared by all downstream nodes (sent only once to each group channel). |
| Group Channel ID namespace is the same as Standard Channel ID namespace on a particular connection. | ||
| Whenever a Standard or Extended Channel is created, it is always put into some Group Channel identified by its `group_channel_id`. | ||
| Group Channel ID namespace is the same as Standard and Extended Channel ID namespace on a particular connection. | ||
|
|
There was a problem hiding this comment.
Should we add some notes about the extranonce constraints when grouping extended channels?
I'm referring to what you pointed out in this comment: #157 (reply in thread)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #157
this PR is modifying the Sv2 Spec so that Group Channels can also contain Extended Channels
most changes should be (relatively) backward compatible, with one exception:
OpenExtendedMiningChannel.Successnow has a new fieldgroup_channel_id