-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump strawberry minumum version to 0.257.0 #688
Conversation
…ith multiple possibilities Follow up to the security fix on Strawberry, which requires changes to this integration as well.
Reviewer's Guide by SourceryThis pull request bumps the minimum version of Strawberry to 0.257.0 and introduces a new No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 89.04% 89.05% +0.01%
==========================================
Files 42 42
Lines 3823 3836 +13
==========================================
+ Hits 3404 3416 +12
- Misses 419 420 +1 ☔ View full report in Codecov by Sentry. |
Bump the minimum version of strawberry to
0.257.0
, which containsstrawberry.cast
and allows us to mitigate GHSA-5xh2-23cc-5jc6