-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow setting max_results for connection fields #689
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new Class diagram for updated connection field structureclassDiagram
class StrawberryDjangoConnectionExtension {
+max_results: Optional[int]
+__init__(max_results: Optional[int])
}
class connection {
+field_name: str
+max_results: Optional[int]
+filters: Optional[type]
+order: Optional[type]
+extensions: Sequence[FieldExtension]
}
class WindowPagination {
+apply_window_pagination()
+offset: int
+limit: Optional[int]
+max_results: Optional[int]
}
connection --> StrawberryDjangoConnectionExtension
StrawberryDjangoConnectionExtension --> WindowPagination
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 42 42
Lines 3836 3836
=======================================
Hits 3416 3416
Misses 420 420 ☔ View full report in Codecov by Sentry. |
Exposing functionality from https://github.com/strawberry-graphql/strawberry/releases/tag/0.258.0