-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pagination guide #1345
add pagination guide #1345
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
==========================================
+ Coverage 96.75% 98.07% +1.31%
==========================================
Files 181 107 -74
Lines 7432 3842 -3590
Branches 1343 562 -781
==========================================
- Hits 7191 3768 -3423
+ Misses 144 41 -103
+ Partials 97 33 -64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks go to me, other than the request change for strings 👍
Assuming that's changed, I'll let @patrick91 give the final sign off
also fix description strings
also fix description strings
Co-authored-by: Nahuel Ambrosini <[email protected]>
for more information, see https://pre-commit.ci
I have hopefully responded to/ changed things as requested by code reviews. So, I assume the only other thing to do here is to make a final review/ merge, or suggest changes. pinging @patrick91 to do the same! |
Is there any problem with this PR being merged? |
@aryaniyaps apologies for letting this PR get so old! I'll review it today 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Sorry again for letting it sit for so long!
Hello everyone, I tried to implement the cursor pagination, but it's not working. |
can you post an issue with what you've tried and what error you get? |
@patrick91
This is just some of the errors I found, please do let me know if I'm missing any information on how to properly apply the cursors. It's my first time using Strawberry and I'm loving it 🍓 |
This PR adds a guide on how to implement pagination in GraphQL
Description
This PR adds a guide on how to implement pagination in GraphQL. It discusses about the common ways we would do pagination (whether GraphQL is involved or not), like cursor-based or offset-based pagination before implementing the same in GraphQL.
Types of Changes
Issues Fixed or Closed by This PR
Checklist