build: Create $(BUILDDIR) with the targets which need the directory #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68420948
changed the title
68420948
changed the title
68420948
changed the title
Contributor
Author
|
Looks to me like commitlint does not recognize the 'build' type. |
Owner
|
Hey, thanks for your contributions :) |
Owner
|
And also, it keeps complaining as you're not editing the commit message only, you're creating a new commit each time. |
Without this patch the creation of $(BUILDDIR) is triggered unrelated by the all target. This only works if all's prerequisites are processed left to right in sequential order. Running the Makefile under make 4.4 (or higher) in --shuffle mode reveals the incorrect dependency by failing to generate $(BUILDDIR)/vpnc, $(BUILDDIR)/cisco-decrypt or $(BUILDDIR)/test-crypto due to the missing directory. The wrong dependency becomes visible as well, moving $(BUILDDIR) to the end of all's prerequisites list. See https://trofi.github.io/posts/238-new-make-shuffle-mode.html for more information.
68420948
force-pushed
the
builddir-patch
branch
from
20c5bcc to
0dbbece
Compare
Contributor
Author
|
Thanks for the rebase hint. The PR should be good now. |
Owner
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the creation of
$(BUILDDIR)is triggered unrelated by the all target. This only works if all's prerequisites are processed left to right in sequential order. Running the Makefile under make 4.4 (or higher) in --shuffle mode reveals the incorrect dependency by failing to generate$(BUILDDIR)/vpnc,$(BUILDDIR)/cisco-decryptor$(BUILDDIR)/test-cryptodue to the missing directory.The wrong dependency becomes visible as well, moving
$(BUILDDIR)to the end of all's prerequisites list.See https://trofi.github.io/posts/238-new-make-shuffle-mode.html for more information.