fix(postgresql): loosen requirements for getPrimaryKeyWhereClause #103
+139
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoueh
requested changes
Sep 16, 2025
Comment on lines
+358
to
+361
| whereClause, err := d.getPrimaryKeyWhereClauseTyped(table, primaryKey, "") | ||
| if err != nil { | ||
| whereClause = getPrimaryKeyWhereClause(primaryKey, "") | ||
| } |
There was a problem hiding this comment.
Why is this a good way of doing it, can you add a comment explaining the reasoning here, we should also log the error minimally in DEBUG mode if it's expected to log a lot of time.
Comment on lines
+327
to
+329
| if err != nil { | ||
| onClause = getPrimaryKeyWhereClause(primaryKey, table.nameEscaped) | ||
| } |
There was a problem hiding this comment.
Same here, add comment as the why it's correct and log error.
maoueh
requested changes
Sep 16, 2025
Comment on lines
+426
to
+429
| primaryKeySelector, err := d.getPrimaryKeyWhereClauseTyped(o.table, o.primaryKey, "") | ||
| if err != nil { | ||
| return "", err | ||
| } |
There was a problem hiding this comment.
Is this backward compatible? The question is essentially, if there is already substreams_history entries`, are they going to be read correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substreams_historywill look like so: