Skip to content

brief asyncio / multiprocessing, remove link to external asyncio guide #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jokester
Copy link
Contributor

@jokester jokester commented May 2, 2025

📚 Context

The medium article linked is IMO inappropriate to be referred to from streamlit doc, because its analysis and workaround to the asyncio hurdle is too arguable:

  1. Tornado server has a event loop, this does not mean it should be used to run user's (potentially blocking) coroutine.
  2. There are apparently other possibilities than run_until_complete, like in Native asyncio support streamlit#8488 (comment) . I think the author assumed too much on the problem to solve.
  3. The workaround it suggested, to monkey patch asyncio module with a library, is too intrusive.

🧠 Description of Changes

  1. a little more comparison about multiprocessing / asyncio in this page
  2. remove the link to the article.

💥 Impact

Size:

  • Small
  • Not small

🌐 References

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@jokester jokester requested a review from a team as a code owner May 2, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant