Skip to content

fix run.sh in kubernetes deploy tutorial - #995

Open
NikiforovG wants to merge 1 commit into
streamlit:mainfrom
NikiforovG:patch-1
Open

fix run.sh in kubernetes deploy tutorial#995
NikiforovG wants to merge 1 commit into
streamlit:mainfrom
NikiforovG:patch-1

Conversation

@NikiforovG

Copy link
Copy Markdown

There was an inconsistent variable name.

📚 Context

🧠 Description of Changes

There was an inconsistent variable name. stopRunningProcess() was looking at APP_PID variable while APP_ID was defined at application run.

Revised:

streamlit run ${HOME}/app/streamlit_app.py &
APP_PID=${!}

wait ${APP_PID}

Current:

streamlit run ${HOME}/app/streamlit_app.py &
APP_ID=${!}

wait ${APP_ID}

💥 Impact

Small typo fix.

Size:

  • Small
  • Not small

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

There was inconsistent variable name
@lukasmasuch

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants