Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avoid printing unexpected messages #206

Merged
merged 2 commits into from
Feb 24, 2025
Merged

feat: avoid printing unexpected messages #206

merged 2 commits into from
Feb 24, 2025

Conversation

mattisonchao
Copy link
Member

Motivation

Improve logs to avoid annoying users.

Modification

  • Change onCompleted logs level to Info and remove completedException.
  • Avoid print stack trace for the onError method because that is an async connection callback. the stack trace is useless.

@mattisonchao mattisonchao self-assigned this Feb 24, 2025
@merlimat merlimat merged commit c167af3 into main Feb 24, 2025
1 check passed
@merlimat merlimat deleted the log.improve branch February 24, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

@RobertIndie RobertIndie Awaiting requested review from RobertIndie RobertIndie is a code owner

Assignees

@mattisonchao mattisonchao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattisonchao @merlimat