Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partitioned topic not change #185

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Fix partitioned topic not change #185

merged 5 commits into from
Jan 29, 2024

Conversation

labuladong
Copy link
Member

@labuladong labuladong requested review from a team as code owners January 26, 2024 07:00
@github-actions GitHub Actions
Copy link
Contributor

@labuladong:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jan 26, 2024
maxsxu
maxsxu approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsyh ericsyh merged commit 99df860 into main Jan 29, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the donglai/fix-partitioned-topic branch January 29, 2024 07:29
@ericsyh ericsyh mentioned this pull request Feb 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsyh ericsyh ericsyh approved these changes

@maxsxu maxsxu maxsxu approved these changes

Assignees

@labuladong labuladong

Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@labuladong @ericsyh @maxsxu