-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add crd for pulsar package & function & connector #206
Conversation
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 226 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
144 | 1 | 81 | 0 |
Click to see the invalid file list
- api/v1alpha1/zz_generated.deepcopy.go
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 243 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
152 | 10 | 81 | 0 |
Click to see the invalid file list
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarconnections.yaml
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarfunctions.yaml
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsargeoreplications.yaml
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarnamespaces.yaml
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarpackages.yaml
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarpermissions.yaml
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarsinks.yaml
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarsources.yaml
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsartenants.yaml
- charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsartopics.yaml
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarconnections.yaml
Show resolved
Hide resolved
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarfunctions.yaml
Show resolved
Hide resolved
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsargeoreplications.yaml
Show resolved
Hide resolved
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarnamespaces.yaml
Show resolved
Hide resolved
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarpackages.yaml
Show resolved
Hide resolved
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarpermissions.yaml
Show resolved
Hide resolved
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarsinks.yaml
Show resolved
Hide resolved
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarsources.yaml
Show resolved
Hide resolved
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsartenants.yaml
Show resolved
Hide resolved
charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsartopics.yaml
Show resolved
Hide resolved
b2bf40a
to
35f6e79
Compare
0d85ad2
to
de600cf
Compare
8a10a3f
to
d5fc9f4
Compare
8e4b238
to
b53083f
Compare
b53083f
to
35c1eb2
Compare
@labuladong Pls take a look this PR. |
@labuladong could you help review this PR ASAP? |
return url | ||
} | ||
if _, err := utils.GetPackageName(url); err != nil { | ||
return "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to return the error too
makeFunctionsReconciler(r), | ||
makeSinksReconciler(r), | ||
makeSourcesReconciler(r), | ||
makePackagesReconciler(r), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulsar-resources-operator/pkg/connection/reconciler.go
Lines 176 to 181 in 087c81e
if r.connection.DeletionTimestamp.IsZero() { | |
for _, reconciler := range r.reconcilers { | |
if err = reconciler.Reconcile(ctx); err != nil { | |
return err | |
} | |
} |
These reconcilers will execute one by one, one fail will block the flowing reconcilers. So the order is important, I think the function reconciler relies on package reconciler? What will happen if you create function resource first, then create package resource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix in #216
I'm reviewing, I think there are some problems in this pr |
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)