Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add crd for pulsar package & function & connector #206

Merged
merged 55 commits into from
Jun 25, 2024

Conversation

freeznet
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Copy link
Contributor

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jun 18, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 226 files.

Valid Invalid Ignored Fixed
144 1 81 0
Click to see the invalid file list
  • api/v1alpha1/zz_generated.deepcopy.go

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 243 files.

Valid Invalid Ignored Fixed
152 10 81 0
Click to see the invalid file list
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarconnections.yaml
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarfunctions.yaml
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsargeoreplications.yaml
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarnamespaces.yaml
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarpackages.yaml
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarpermissions.yaml
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarsinks.yaml
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsarsources.yaml
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsartenants.yaml
  • charts/pulsar-resources-operator/crds/resource.streamnative.io_pulsartopics.yaml

@freeznet freeznet force-pushed the freeznet/add-functions-connectors-admin branch from b2bf40a to 35f6e79 Compare June 21, 2024 10:08
@freeznet freeznet force-pushed the freeznet/add-functions-connectors-admin branch from 0d85ad2 to de600cf Compare June 21, 2024 10:36
@freeznet freeznet force-pushed the freeznet/add-functions-connectors-admin branch from 8a10a3f to d5fc9f4 Compare June 21, 2024 11:40
@freeznet freeznet force-pushed the freeznet/add-functions-connectors-admin branch from 8e4b238 to b53083f Compare June 21, 2024 12:20
@freeznet freeznet force-pushed the freeznet/add-functions-connectors-admin branch from b53083f to 35c1eb2 Compare June 21, 2024 12:25
@freeznet freeznet marked this pull request as ready for review June 21, 2024 12:44
@freeznet freeznet requested review from a team as code owners June 21, 2024 12:44
nlu90
nlu90 previously approved these changes Jun 21, 2024
@ericsyh
Copy link
Member

ericsyh commented Jun 24, 2024

@labuladong Pls take a look this PR.

@ericsyh ericsyh added this to the 0.5.0 milestone Jun 24, 2024
@freeznet freeznet requested review from labuladong and ericsyh June 24, 2024 04:09
@nlu90
Copy link
Contributor

nlu90 commented Jun 25, 2024

@labuladong could you help review this PR ASAP?

@nlu90 nlu90 merged commit 59f126f into main Jun 25, 2024
10 checks passed
@nlu90 nlu90 deleted the freeznet/add-functions-connectors-admin branch June 25, 2024 02:34
return url
}
if _, err := utils.GetPackageName(url); err != nil {
return ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to return the error too

makeFunctionsReconciler(r),
makeSinksReconciler(r),
makeSourcesReconciler(r),
makePackagesReconciler(r),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if r.connection.DeletionTimestamp.IsZero() {
for _, reconciler := range r.reconcilers {
if err = reconciler.Reconcile(ctx); err != nil {
return err
}
}

These reconcilers will execute one by one, one fail will block the flowing reconcilers. So the order is important, I think the function reconciler relies on package reconciler? What will happen if you create function resource first, then create package resource?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix in #216

@labuladong
Copy link
Member

I'm reviewing, I think there are some problems in this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants