Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix oauth2 key secret ref hash #239

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix oauth2 key secret ref hash #239

merged 2 commits into from
Aug 21, 2024

Conversation

freeznet
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

When using OAuth2 with Key SecretRef, the secret hash will not update to status and may causing the missing refresh when secret changed.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Aug 21, 2024
@freeznet freeznet requested review from a team as code owners August 21, 2024 15:18
Copy link
Contributor

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Aug 21, 2024
nlu90
nlu90 previously approved these changes Aug 21, 2024
@freeznet
Copy link
Member Author

Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions --timeout=5m] in [] ...
  Error: cyclomatic complexity 35 of func `(*PulsarConnectionReconciler).Reconcile` is high (> 30) (gocyclo)
  

@freeznet freeznet merged commit 4966635 into main Aug 21, 2024
5 checks passed
@freeznet freeznet deleted the freeznet/fix-secret-key-hash branch August 21, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants