Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ns offload policy #250

Merged
merged 6 commits into from
Sep 4, 2024
Merged

feat: support ns offload policy #250

merged 6 commits into from
Sep 4, 2024

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Sep 2, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #235

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ericsyh ericsyh requested review from a team as code owners September 2, 2024 06:21
@github-actions github-actions bot added the doc-required This pr needs a document label Sep 2, 2024
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
@ericsyh
Copy link
Member Author

ericsyh commented Sep 3, 2024

Test record

apiVersion: resource.streamnative.io/v1alpha1
kind: PulsarNamespace
metadata:
  name: test-ns
  namespace: resource
spec:
  name: test-tenant/testns
  connectionRef:
    name: pulsar-connection
  retentionTime: 20h
  retentionSize: 2Gi
  offloadThresholdTime: 10h
  offloadThresholdSize: 5Gi
pulsar-admin namespaces get-offload-policies test-tenant/testns
{
  "offloadersDirectory" : "./offloaders",
  "managedLedgerOffloadMaxThreads" : 2,
  "managedLedgerOffloadPrefetchRounds" : 1,
  "managedLedgerOffloadThresholdInSeconds" : 36000,
  "managedLedgerOffloadThresholdInBytes" : 5368709120,
  "managedLedgerOffloadedReadPriority" : "TIERED_STORAGE_FIRST",
  "managedLedgerExtraConfigurations" : { },
  "s3ManagedLedgerOffloadMaxBlockSizeInBytes" : 67108864,
  "s3ManagedLedgerOffloadReadBufferSizeInBytes" : 1048576,
  "s3ManagedLedgerOffloadRoleSessionName" : "pulsar-s3-offload",
  "gcsManagedLedgerOffloadMaxBlockSizeInBytes" : 67108864,
  "gcsManagedLedgerOffloadReadBufferSizeInBytes" : 1048576,
  "s3Driver" : false,
  "gcsDriver" : false,
  "fileSystemDriver" : false
}

@ericsyh ericsyh merged commit 0a10ea2 into main Sep 4, 2024
6 checks passed
@ericsyh ericsyh deleted the support-ns-offload-policy branch September 4, 2024 02:52
@ericsyh ericsyh added this to the v0.6.0 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required This pr needs a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support set-offload-threshold for tiered storage
2 participants