Conversation
Co-authored-by: streed <805140+streed@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive settings UI that provides full parity with the CLI configuration commands, allowing users to configure all ML Notes application settings through the web interface.
Key changes include:
- Removal of non-existent configuration fields and addition of missing ones in the settings template
- Enhanced API support for all configuration fields including new LilRag integration and auto-tag model settings
- Updated CLI config command to include the missing
lilrag-urloption
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| web/templates/settings.html | Replaced non-existent vector search fields with proper configuration sections for LilRag, auto-tag model, and web UI theme |
| internal/api/server.go | Added support for new configuration fields in API handlers and request/response structures |
| cmd/config.go | Added missing lilrag-url configuration option and updated help documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if req.AutoTagModel != "" { | ||
| newCfg.AutoTagModel = req.AutoTagModel | ||
| } |
There was a problem hiding this comment.
The auto tag model field should allow empty strings to be set (to clear the value), but this condition prevents empty strings from being processed. Consider checking if the field exists in the request rather than if it's non-empty.
| if req.LilRagURL != "" { | ||
| newCfg.LilRagURL = req.LilRagURL | ||
| } |
There was a problem hiding this comment.
Similar to the auto tag model, this condition prevents clearing the LilRag URL by setting it to an empty string. The field should be updateable to empty values.
| if req.LilRagURL != "" { | |
| newCfg.LilRagURL = req.LilRagURL | |
| } | |
| newCfg.LilRagURL = req.LilRagURL |
| if req.WebUITheme != "" { | ||
| newCfg.WebUITheme = req.WebUITheme | ||
| } |
There was a problem hiding this comment.
This condition prevents clearing the WebUI theme setting. Consider allowing empty strings to reset to default theme behavior.
| if req.WebUITheme != "" { | |
| newCfg.WebUITheme = req.WebUITheme | |
| } | |
| newCfg.WebUITheme = req.WebUITheme |
This PR implements a complete settings UI that allows users to configure all ML Notes application settings from the web interface, providing the same functionality as the CLI
ml-notes config setcommand.Problem
The existing settings UI was incomplete and had several issues:
EnableVectorSearch,EmbeddingModel,VectorDimensions)lilrag-urloptionSolution
Enhanced CLI Configuration
lilrag-urlsupport toml-notes config setcommandComplete Settings UI Implementation
settings.htmlto use correct field names from the Config structlilrag_url) for enhanced semantic searchauto_tag_model)webui_theme)UpdateSettingsRequeststruct and handlers to support all configuration fieldsFunctionality Verified
Configuration Options Now Available in UI
The settings UI now provides complete parity with the CLI configuration commands, allowing users to manage their ML Notes setup entirely through the web interface.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.