-
Notifications
You must be signed in to change notification settings - Fork 0
Enhance install script to automatically install dependencies on first install #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
streed
merged 6 commits into
main
from
copilot/fix-700df305-6a98-4aeb-bb43-47029478bb9b
Sep 12, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d89875d
Initial plan
Copilot 4f075be
Add first-install detection and dependency installation to install scβ¦
Copilot 88b911c
Update install.sh
streed 9d60a84
Improve error handling for first-install dependencies to be non-fatal
Copilot 4848e91
Fix install command syntax for lil-rag installation
Copilot 0c6eb90
Use lil-rag repository's install.sh script for installation
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trap is set inside the function scope and will only execute when the function exits, not when the script exits. If the script is interrupted or fails elsewhere after calling this function, the temporary directory may not be cleaned up. Move the trap outside the function or use a global cleanup mechanism.