Split Strimzi Metrics Reporter defaults by Kafka node role - #12970
Closed
MARKOCEVRLJAKOVIC wants to merge 1 commit into
Closed
Split Strimzi Metrics Reporter defaults by Kafka node role#12970MARKOCEVRLJAKOVIC wants to merge 1 commit into
MARKOCEVRLJAKOVIC wants to merge 1 commit into
Conversation
Add separate default allow lists for broker-only and controller-only nodes while preserving the combined defaults for mixed-role nodes. Keep custom allow lists unchanged and add tests for the new behavior. Closes strimzi#12181
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Member
|
Thanks for the PR. However, I think that is already being worked on in #12966 |
Author
|
Thanks for letting me know. There was no PR open for this issue when I started working on it. I'll close this one to avoid duplicate work. If useful, feel free to reuse any ideas or tests from this branch. |
Member
|
Yeah, the PR is pretty new. Sorry. Maybe you can just write on the issue when you start working on it so that others know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12181
Description
This change splits the default Strimzi Metrics Reporter allow list by Kafka node role.
values.allowListcontinues to take precedence for all node rolesThe node-role selection is handled in
KafkaCluster, whileStrimziMetricsReporterModelremains role-agnostic by accepting the appropriate default allow list from the caller.Testing