Skip to content

Split Strimzi Metrics Reporter defaults by Kafka node role - #12970

Closed
MARKOCEVRLJAKOVIC wants to merge 1 commit into
strimzi:mainfrom
MARKOCEVRLJAKOVIC:12181-metrics-allow-list-per-role
Closed

Split Strimzi Metrics Reporter defaults by Kafka node role#12970
MARKOCEVRLJAKOVIC wants to merge 1 commit into
strimzi:mainfrom
MARKOCEVRLJAKOVIC:12181-metrics-allow-list-per-role

Conversation

@MARKOCEVRLJAKOVIC

Copy link
Copy Markdown

Fixes #12181

Description

This change splits the default Strimzi Metrics Reporter allow list by Kafka node role.

  • broker-only nodes use broker-specific metrics together with shared metrics
  • controller-only nodes use controller-specific metrics together with shared metrics
  • mixed broker/controller nodes continue using the combined default allow list
  • custom values.allowList continues to take precedence for all node roles

The node-role selection is handled in KafkaCluster, while StrimziMetricsReporterModel remains role-agnostic by accepting the appropriate default allow list from the caller.

Testing

  • Added unit tests for broker-only, controller-only and mixed-role default allow lists.
  • Added tests verifying that custom allow lists override role-specific defaults.

Add separate default allow lists for broker-only and controller-only
nodes while preserving the combined defaults for mixed-role nodes.
Keep custom allow lists unchanged and add tests for the new behavior.

Closes strimzi#12181
@snyk-io

snyk-io Bot commented Jul 20, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@scholzj

scholzj commented Jul 20, 2026

Copy link
Copy Markdown
Member

Thanks for the PR. However, I think that is already being worked on in #12966

@MARKOCEVRLJAKOVIC

Copy link
Copy Markdown
Author

Thanks for letting me know. There was no PR open for this issue when I started working on it. I'll close this one to avoid duplicate work. If useful, feel free to reuse any ideas or tests from this branch.

@scholzj

scholzj commented Jul 20, 2026

Copy link
Copy Markdown
Member

Yeah, the PR is pretty new. Sorry. Maybe you can just write on the issue when you start working on it so that others know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should Strimzi Metrics Reporter use separate default values for controller and broker nodes?

2 participants