Narrow example JMX exporter rules for socket, raft-channel and RequestMetrics - #13139
Open
guancioul wants to merge 1 commit into
Open
Narrow example JMX exporter rules for socket, raft-channel and RequestMetrics#13139guancioul wants to merge 1 commit into
guancioul wants to merge 1 commit into
Conversation
…tMetrics Signed-off-by: guancioul <guancioul@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13139 +/- ##
============================================
+ Coverage 80.58% 80.89% +0.31%
- Complexity 6581 6738 +157
============================================
Files 344 355 +11
Lines 22777 23072 +295
Branches 3111 3148 +37
============================================
+ Hits 18355 18665 +310
+ Misses 3204 3180 -24
- Partials 1218 1227 +9 🚀 New features to boost your workflow:
|
ppatierno
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Following the metrics survey and discussion in #10188, this narrows the example JMX Prometheus Exporter rules (
packaging/examples/metrics/kafka-metrics.yaml) to only export the metrics actually used by the shipped Grafana dashboards and Prometheus alert rules:socket-server-metrics: keep onlyconnection-count, drop the rest.raft-channel-metrics: keep onlyincoming-byte-total,outgoing-byte-total,request-total,response-total.RequestMetricsentirely from the generic catch-all rules (contributed ~22 unused metric types).The Strimzi Metrics Reporter example (
packaging/examples/metrics/strimzi-metrics-reporter/kafka-metrics.yaml) is intentionally left untouched, itsallowListmechanism is allow-only (no deny), so matching this exclusion needs a different approach and will be addressed separately.AI assistance disclosure: Claude Code was used to help draft the narrowed regex rules and to run local verification (spinning up real Kafka brokers via Docker with the old/new JMX exporter config and diffing the scraped metrics). I reviewed all changes, understand them, and can answer questions about them.
Checklist