Do not make ANONYMOUS superuser when with none authentication - #13142
Open
scholzj wants to merge 1 commit into
Open
Do not make ANONYMOUS superuser when with none authentication#13142scholzj wants to merge 1 commit into
ANONYMOUS superuser when with none authentication#13142scholzj wants to merge 1 commit into
Conversation
Signed-off-by: Jakub Scholz <www@scholzj.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13142 +/- ##
============================================
- Coverage 80.88% 80.85% -0.03%
+ Complexity 6737 6736 -1
============================================
Files 355 355
Lines 23072 23071 -1
Branches 3148 3148
============================================
- Hits 18662 18655 -7
- Misses 3183 3187 +4
- Partials 1227 1229 +2
🚀 New features to boost your workflow:
|
Member
Author
|
/gha run pipeline=regression clusterSecurityEncryption=none clusterSecurityAuthentication=none |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
|
❌ System test verification failed: link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Originally, when the internal cluster authentication was disabled, we automatically configure the
ANONYMOUSuser as superuser. Looking back, I think that was a mistake as it is disaster in waiting (e.g. similarly to the watched namespaces CVE). So this PR rolls that back. If users want to use thetype: noneauthentication with authorization, they should make the ANONYMOUS user explicitly to make sure they are aware of this.Checklist