Skip to content

Do not make ANONYMOUS superuser when with none authentication - #13142

Open
scholzj wants to merge 1 commit into
strimzi:mainfrom
scholzj:avoid-automatically-superusering-ANONYMOUS-with-none-authentication
Open

Do not make ANONYMOUS superuser when with none authentication#13142
scholzj wants to merge 1 commit into
strimzi:mainfrom
scholzj:avoid-automatically-superusering-ANONYMOUS-with-none-authentication

Conversation

@scholzj

@scholzj scholzj commented Sep 9, 2026

Copy link
Copy Markdown
Member

Type of Change

  • Task

Description

Originally, when the internal cluster authentication was disabled, we automatically configure the ANONYMOUS user as superuser. Looking back, I think that was a mistake as it is disaster in waiting (e.g. similarly to the watched namespaces CVE). So this PR rolls that back. If users want to use the type: none authentication with authorization, they should make the ANONYMOUS user explicitly to make sure they are aware of this.

Checklist

  • Update documentation
  • Make sure all tests pass
  • Try your changes inside a Kubernetes cluster, not just from unit tests

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 1.3.0 milestone Sep 9, 2026
@scholzj
scholzj requested a review from a team September 9, 2026 23:05
@snyk-io

snyk-io Bot commented Sep 9, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.85%. Comparing base (40768d3) to head (03898d0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13142      +/-   ##
============================================
- Coverage     80.88%   80.85%   -0.03%     
+ Complexity     6737     6736       -1     
============================================
  Files           355      355              
  Lines         23072    23071       -1     
  Branches       3148     3148              
============================================
- Hits          18662    18655       -7     
- Misses         3183     3187       +4     
- Partials       1227     1229       +2     
Files with missing lines Coverage Δ
...cluster/model/KafkaBrokerConfigurationBuilder.java 94.72% <ø> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scholzj

scholzj commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

/gha run pipeline=regression clusterSecurityEncryption=none clusterSecurityAuthentication=none

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

⏳ System test verification started: link
Internal cluster security: encryption none, authentication none

The following 6 job(s) will be executed:

  • regression-brokers-and-security-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operators-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operands-amd64 (cncf-ubuntu-8-32-x86)
  • regression-brokers-and-security-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operators-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operands-arm64 (cncf-ubuntu-8-32-arm)

Tests will start after successful build completion.

@github-actions

Copy link
Copy Markdown

❌ System test verification failed: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant