Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Kms submodules #35

Closed
wants to merge 2 commits into from
Closed

Kms submodules #35

wants to merge 2 commits into from

Conversation

chris-giblin
Copy link
Contributor

This PR can be viewed as a study but also as a real candidate for main. It incorporates:

The kms refactoring replaces the type field in the config json with a field for the classname of the respective kms provider. This allows easy drop-in of new kms providers, not requiring source changes to KmsFactory. For example,

[
  {
    "name"         : "vault-test",
    "kmsClassname" : "io.strimzi.kafka.topicenc.kms.vault.VaultKms",
    "uri"          : "http://127.0.0.1:8200/v1/secret/data/test",
    "credential"   : "s.3gxh8p83kxkTv9IB66GmORtK"
  },
  {
    "name"         : "test",
    "kmsClassname" : "io.strimzi.kafka.topicenc.kms.test.TestKms"
  },
  {
    "name"         : "cloud",
    "kmsClassname" : "io.strimzi.kafka.topicenc.kms.keyprotect.KeyProtectKms",
    "uri"          : "http://sfsffs.ibm.com/abc",
    "instanceId"   : "shdjkjahkjahd",
    "credential"   : "<apikey>"
  }
]

@tombentley
Copy link
Member

Thanks @chris-giblin. I took a quick look and this looks promising. I think it needs rebasing before I can give it a proper review, because it includes a lot of stuff from the recently reviewed/merged PRs so it's difficult to see the wood for the trees right now.

@chris-giblin
Copy link
Contributor Author

Agree, things have become messy. I am closing this PR and will work up to it in a series of smaller steps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants