[Connect SDK] Update Connect example app to use Hilt dependency injection #9579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Risky Change This is considered a risky change because it adjusts the sample app build.gradle, please review carefully. By adding the label |
simond-stripe
changed the title
|
Diffuse output: APK |
simond-stripe
force-pushed
the
simond/connect-example-to-hilt
branch
from
140896b
to
2361fcf
Compare
lng-stripe
requested changes
Nov 8, 2024
| ) : ViewModel() { | ||
|
|
||
| private val logger: Logger = Logger.getInstance(enableLogging = BuildConfig.DEBUG) |
There was a problem hiding this comment.
Should add the logger to DI graph as well but can do in follow-ups.
There was a problem hiding this comment.
We talked, I'll do this in a follow-up
| import kotlinx.coroutines.launch | ||
| import java.io.IOException | ||
|
|
||
| @OptIn(PrivateBetaConnectSDK::class) | ||
| class EmbeddedComponentManagerWrapper private constructor() { | ||
| class EmbeddedComponentManagerWrapper( |
There was a problem hiding this comment.
Suggested change
| class EmbeddedComponentManagerWrapper( | |
| @Singleton | |
| class EmbeddedComponentManagerWrapper @Inject constructor( |
|
|
||
| class EmbeddedComponentService private constructor( | ||
| private val settingsService: SettingsService = SettingsService.getInstance(), | ||
| class EmbeddedComponentService @Inject constructor( |
There was a problem hiding this comment.
Suggested change
| class EmbeddedComponentService @Inject constructor( | |
| @Singleton | |
| class EmbeddedComponentService @Inject constructor( |
Comment on lines
14
to
16
| @Module | ||
| @InstallIn(SingletonComponent::class) | ||
| object ServiceModule { |
There was a problem hiding this comment.
I don't think this is necessary if we use the @Singleton annotation appropriately, right?
There was a problem hiding this comment.
Huh, I didn't realize this annotation existed. Much better, and yes we shouldn't need this module anymore!
| class SettingsService private constructor(context: Context) { | ||
| class SettingsService @Inject constructor(context: Context) { |
There was a problem hiding this comment.
Suggested change
| class SettingsService private constructor(context: Context) { | |
| class SettingsService @Inject constructor(context: Context) { | |
| @Singleton | |
| class SettingsService @Inject constructor( | |
| @ApplicationContext context: Context | |
| ) { |
lng-stripe
approved these changes
Nov 9, 2024
amk-stripe
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrate Hilt into the example app.
Motivation
The connect example app is getting more complicated, and integrating Hilt will make it faster (and less error-prone) to test.
Testing
I tested all of the flow (there aren't many of them) and tested that they still work + don't crash.
Screenshots
demo-1731098981.mp4