[Next Major] prevent autopagination from mutating #2899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes
.ListAutoPaging
and.SearchAutoPaging
not to mutate the user-providedoptions
argument.Before this change, there would be a subtle bug/confusing behavior if you ever re-used the same
options
across multiple list requests: e.g. suppose there are 4 customers ["a", "b", "c", "d"].There's a small chance that a user is dependent on this behavior, e.g. you can imagine somebody doing
so out of conservatism I would wait to change this behavior until the next major version but I'm open to persuasion just to ship it.