Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PaymentSheet didSelectPayWithLink delegate flow #3571

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuki-stripe
Copy link
Collaborator

Motivation

Cleaner if PaymentSheetViewController is responsible for this - it can clear its text fields, hide the keyboard etc. when Link payment starts. Will make it cleaner for Vertical mode, too, since it will do different things (no text fields to clear or keyboard to hide).

Testing

Manually tested Link animations

Simulator.Screen.Recording.-.snapshot.tester.iPhone.12.mini.16.4.-.2024-05-08.at.11.24.48.mp4

Changelog

Not user facing

@yuki-stripe yuki-stripe requested review from a team as code owners May 8, 2024 18:42
@yuki-stripe yuki-stripe marked this pull request as draft May 8, 2024 18:43
@yuki-stripe
Copy link
Collaborator Author

Not actually sure this is better, changing to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants