Add support for id_consent_content pane #4644
Draft
+435
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 New dead code detected in this PR: FinancialConnectionsGenericInfoScreen.swift:65 warning: Struct 'TypeDecodingContainer' is unused
IDConsentContentViewController.swift:20 warning: Parameter 'viewController' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
mats-stripe
force-pushed
the
mats/add_id_consent_content_pane
branch
from
9b03a9a to
72822f5
Compare
mats-stripe
commented
Mar 10, 2025
| @@ -106,29 +106,6 @@ final class ConsentLogoView: UIView { | |||
| } | |||
| } | |||
|
|
|||
| private func CreateRoundedLogoView(urlString: String) -> UIView { | |||
There was a problem hiding this comment.
Moved to be shared with the new pane
|
|
||
| import Foundation | ||
|
|
||
| struct FinancialConnectionsIDConsentContent: Decodable { |
There was a problem hiding this comment.
mats-stripe
force-pushed
the
mats/add_id_consent_content_pane
branch
from
499e215 to
412209b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the institution picker first experiment, a new pane
id_consent_contentis added. It's mostly identical to the consent pane, with a few minor adjustments.Motivation
Support institution picker first experiment.
Testing
Coming soon
Changelog
N/a