-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC Lite in MPE prototype #4659
base: master
Are you sure you want to change the base?
FC Lite in MPE prototype #4659
Conversation
🚨 New dead code detected in this PR: AuthFlowViewController.swift:23 warning: Property 'webAuthenticationSession' is assigned, but never used
ContainerViewController.swift:20 warning: Property 'authFlowViewController' is assigned, but never used
FinancialConnectionsLite.swift:33 warning: Property 'activeInstance' is assigned, but never used
ConnectionsSDKAvailability.swift:14 warning: Property 'FinancialConnectionsSDKClass' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
1 build increased size, 6 builds decreased size, 1 build had no size change
StripeSize 1.0 (1)
|
Item | Install Size Change |
---|---|
🗑 StripeUICore.CheckboxButton.handleEvent | ⬇️ -564 B |
Other | ⬇️ -372 B |
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 16 B
Total download size change: ⬇️ 109 B
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬇️ -16 B |
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 944 B (-0.01%)
Total download size change: ⬇️ 718 B (-0.04%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripeUICore.CheckboxButton.handleEvent | ⬇️ -564 B |
Other | ⬇️ -380 B |
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 185.1 kB (1.66%)
Total download size change: ⬆️ 67.7 kB (1.78%)
Largest size changes
Item | Install Size Change |
---|---|
StripePaymentSheet.PaymentSheet.paymentSheetViewControllerShouldC... | ⬇️ -8.0 kB |
Code Signature | ⬆️ 4.6 kB |
StripePaymentSheet.PaymentSheet.payWithLinkViewControllerDidConfi... | ⬇️ -3.8 kB |
📝 WKUIDelegate.Objc Metadata | ⬆️ 2.9 kB |
StripePaymentSheet.BottomSheetViewController.init(contentViewCont... | ⬇️ -2.9 kB |
StripeIdentitySize 1.0 (1)
com.stripe.StripeIdentitySize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 968 B (-0.02%)
Total download size change: ⬇️ 152 B (-0.01%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripeUICore.CheckboxButton.handleEvent | ⬇️ -564 B |
Other | ⬇️ -404 B |
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
No changes to report
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 968 B (-0.02%)
Total download size change: ⬇️ 495 B (-0.03%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripeUICore.CheckboxButton.handleEvent | ⬇️ -564 B |
Other | ⬇️ -404 B |
StripeConnectSize 1.0 (1)
com.stripe.StripeConnectSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 1.0 kB (-0.02%)
Total download size change: ⬇️ 483 B (-0.03%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripeUICore.CheckboxButton.handleEvent | ⬇️ -564 B |
Other | ⬇️ -476 B |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
7e59072
to
0fd9ce3
Compare
Summary
Motivation
Testing
Changelog