Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't select form payment option if no previous selection #4661

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't select form payment option if no previous selection #4661

wants to merge 3 commits into from

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Mar 12, 2025 •
edited
Loading

Summary

  • When we close the form, we no longer select what is populated in the form even if it is a valid payment option, if there was no previous customer selection.
  • Fixed a bug where we were updating the payment option to the merchant when a form was presented (before the user tapped Continue in the form).

Motivation

Testing

  • Manual
  • New unit test

Changelog

N/A

@porter-stripe porter-stripe changed the title Don't select form contents if no previous selection Don't select form payment option if no previous selection Mar 12, 2025
@porter-stripe porter-stripe marked this pull request as ready for review March 13, 2025 15:14
@porter-stripe porter-stripe requested review from a team as code owners March 13, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-stripe yuki-stripe Awaiting requested review from yuki-stripe

At least 1 approving review is required to merge this pull request.

Assignees

@yuki-stripe yuki-stripe

Labels
embedded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porter-stripe @yuki-stripe