Extract HostedAuthUrlBuilder to StripeCore #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
previously approved these changes
Mar 27, 2025
mats-stripe
force-pushed
the
mats/extract_hostedauthurl_builder_to_stripecore
branch
from
2bb2d4d to
e975ba3
Compare
mats-stripe
force-pushed
the
mats/fc_lite_availability_in_mpe
branch
from
ee0a191 to
f793248
Compare
mats-stripe
force-pushed
the
mats/extract_hostedauthurl_builder_to_stripecore
branch
from
e975ba3 to
10dd6ee
Compare
mats-stripe
force-pushed
the
mats/fc_lite_availability_in_mpe
branch
from
58d8ed9 to
14d244d
Compare
mats-stripe
force-pushed
the
mats/extract_hostedauthurl_builder_to_stripecore
branch
from
10dd6ee to
d3efb4e
Compare
mats-stripe
force-pushed
the
mats/extract_hostedauthurl_builder_to_stripecore
branch
from
d3efb4e to
61f6ce0
Compare
tillh-stripe
approved these changes
Mar 28, 2025
mats-stripe
deleted the
mats/extract_hostedauthurl_builder_to_stripecore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the hosted auth URL building logic from the FC SDK into StripeCore for reuse in FC Lite. This will ensure we pass along the same parameters to the hosted auth flow, and will fix bugs we found during the bug bash, like fixing Panther!
There should be no functional changes introduced for the full SDK here.
Motivation
Ensures consistency in the hosted auth flow URLs we launch from either FC Lite or the full FC SDK.
Testing
Lots of unit tests added!
Changelog
N/a - FC Lite isn't released yet.