Update StripeClient to optionally take app_info in parameter

[JacekD98]

#1524

Why?

It can be annoying to be dynamically setting the app info based on the execution context for every http request, as you need to take care to reset it to what it was before. Before, you need to do something along the lines of:

def xyz
  previous_app_info = Stripe.app_info
  some_condition = Foo.condition?
  
  Stripe.set_app_info("bar") if some_condition
  
  stripe_client.request do
    return block.call
  end
ensure
 Stripe.app_info = previous_app_info if some_condition
end

and then wrap your requests, in the case of an app info changing dynamically.

What?

• Update StripeClient to take in an optional app_info parameter
• Make the ApiRequestor check first for said app_info, before falling back to the global app_info

Allow a StripeClient initializer to take in an optional app_info param, that will override the global app_info for that instance of the client. This allows you to decide the app info in a certain execution context in a way that is isolated from any other contexts and doesn't have to take care to reset the app info to what it may have been before.

See Also

[cla-assistant]

All committers have signed the CLA.

[JacekD98]

@helenye-stripe could you give this a review please? 🙇

[helenye-stripe]

Hi @JacekD98 ! So sorry, we're discussing this change internally and will get back to you soon.

[xavdid-stripe]

@JacekD98 Thanks for the contributions and sorry again for the delay!

Folks from our respective employers have communicated about how to best handle the underlying problem that app_info solves and I believe we've all agreed to pursue other avenues. So we'll close this PR for now and can revisit if Stripe's API Platform team decides they want to go this direction.