Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InvoiceLineItem parent class #1536

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Fix InvoiceLineItem parent class #1536

merged 2 commits into from
Feb 21, 2025

Conversation

helenye-stripe
Copy link
Contributor

@helenye-stripe helenye-stripe commented Feb 21, 2025 •
edited
Loading

Why?

The request_stripe_object is undefined, fix parent class. Issue raised in #1535

What?

Change parent class from StripeObject to APIResource, and add a test for invoice line item update

See Also

Changelog

  • Fix bug where Stripe::InvoiceLineItem had the incorrect parent class, making it error when update was called

@helenye-stripe helenye-stripe requested a review from a team as a code owner February 21, 2025 16:25
@helenye-stripe helenye-stripe requested review from prathmesh-stripe and removed request for a team February 21, 2025 16:25
Classicrichblog
Classicrichblog reviewed Feb 21, 2025
View reviewed changes
Copy link

@Classicrichblog Classicrichblog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for me

@helenye-stripe helenye-stripe merged commit d7e4457 into master Feb 21, 2025
14 checks passed
@helenye-stripe helenye-stripe deleted the helenye-invoicelineitem branch February 21, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Classicrichblog Classicrichblog Classicrichblog left review comments

@prathmesh-stripe prathmesh-stripe prathmesh-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helenye-stripe @Classicrichblog @prathmesh-stripe