Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when passing non-string to custom method #810

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Jul 15, 2019

Raises a slightly more helpful error message when passing a non-string
to a custom method (currently, it reads "no implicit conversion of Hash
into String", which is terrible).

This a partial remediation for the problem encountered in #809.

r? @ob-stripe

Raises a slightly more helpful error message when passing a non-string
to a custom method (currently, it reads "no implicit conversion of Hash
into String", which is terrible).

This a partial remediation for the problem encountered in #809.
@brandur-stripe
Copy link
Contributor

Thanks!

@brandur-stripe brandur-stripe merged commit ec015a2 into master Jul 16, 2019
@brandur-stripe brandur-stripe deleted the brandur-raise-argument-error branch July 16, 2019 00:06
@brandur-stripe
Copy link
Contributor

Released as 4.21.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants