Drop support for old versions of Ruby #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur-stripe
force-pushed
the
brandur-drop-old-ruby
branch
2 times, most recently
from
7da7070
to
5b3c4a3
Compare
Drops support for Ruby 2.1 (EOL March 31, 2017) and 2.2 (EOL March 31,
2018). They're removed from `.travis.yml` and the gemspec and RuboCop
configuration have also been updated to the new lower bound.
Most of the diff here are minor updates to styling as required by
RuboCop:
* String literals are frozen by default, so the `.freeze` we had
everywhere is now considered redundant.
* We can now use Ruby 1.9 style hash syntax with string keys like `{
"foo": "bar" }`.
* Converted a few heredocs over to use squiggly (leading whitespace
removed) syntax.
As discussed in Slack, I didn't drop support for Ruby 2.3 (EOL March 31,
2019) as we still have quite a few users on it. As far as I know
dropping it doesn't get us access to any major syntax improvements or
anything, so it's probably not a big deal.
brandur-stripe
force-pushed
the
brandur-drop-old-ruby
branch
from
5b3c4a3
to
9ff42b6
Compare
|
cc @rattrayalex-stripe. This isn't going to be merged in |
|
Thanks OB!
Oops, yep, good call mentioning Alex. There was quite a few lines changed in the diff here, but hopefully there will be few needed in the generation code because it's really just the same string in a whole bunch of files. |
|
Nice!! And yeah thanks for heads-up, as brandur noted should be trivial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for Ruby 2.1 (EOL March 31, 2017) and 2.2 (EOL March 31,
2018). They're removed from
.travis.ymland the gemspec and RuboCopconfiguration have also been updated to the new lower bound.
Most of the diff here are minor updates to styling as required by
RuboCop:
String literals are frozen by default, so the
.freezewe hadeverywhere is now considered redundant.
We can now use Ruby 1.9 style hash syntax with string keys like
{ "foo": "bar" }.Converted a few heredocs over to use squiggly (leading whitespace
removed) syntax.
As discussed in Slack, I didn't drop support for Ruby 2.3 (EOL March 31,
2019) as we still have quite a few users on it. As far as I know
dropping it doesn't get us access to any major syntax improvements or
anything, so it's probably not a big deal.
r? @ob-stripe
cc @stripe/api-libraries
Note: Targets the branch
integration-v5in #815 instead ofmaster.