This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Drop Node.js 6 support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virkt25
reviewed
Feb 2, 2018
index.js
Outdated
| module.exports = nodeMajorVersion >= 7 ? | ||
| require('./dist/src') : | ||
| require('./dist6/src'); | ||
| module.exports = require('./dist/src'); |
There was a problem hiding this comment.
Can we switch this to be just ./dist like we have in loopback-next packages?
richardpringle
approved these changes
Feb 2, 2018
virkt25
approved these changes
Feb 5, 2018
b-admike
force-pushed
the
build/drop-node6
branch
3 times, most recently
from
912b622 to
dbccf86
Compare
shimks
reviewed
Feb 7, 2018
test/unit/dummy-test.js
Outdated
| @@ -0,0 +1,7 @@ | |||
| import {expect} from '@loopback/testlab'; | |||
|
|
|||
| describe('dummy test - remove me later', () => { | |||
There was a problem hiding this comment.
What's the purpose of the dummy test here?
There was a problem hiding this comment.
CI thinks that having no tests found is a failure, so this is just a placeholder.
There was a problem hiding this comment.
In that case, I think we should comment on the test to describe the purpose of its presence and explicitly state to remove it once some tests are made.
b-admike
force-pushed
the
build/drop-node6
branch
from
dbccf86 to
a62d0ea
Compare
LoopBack4 is dropping support for Node 6 because it is no longer LTS and doesn't support newer features. It's best for extensions to align with it. Also added a dummy unit test, and updated dependencies. BREAKING CHANGE: Support for Node.js version lower than 8.0 has been dropped. Please upgrade to Node 8 or higher.
b-admike
force-pushed
the
build/drop-node6
branch
from
e66f3b5 to
524fdce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoopBack4 is dropping support for Node 6 because it is no longer LTS and doesn't support newer features. It's best for extensions to align with it.
BREAKING CHANGE: Support for Node.js version lower than 8.0 has been dropped. Please upgrade to Node 8 or higher.
Connect to loopbackio/loopback-next#611