Skip to content

Conversation

@sttk
Copy link
Owner

@sttk sttk commented Jul 26, 2025

This PR removes sub packages and moves program element in them to the root package.

The reason for this modification is as follows:

  • The sub package name errors conflicts the one of go standard package.
  • Not only the root package but also its sub-packages must be imported.

NOTE: This PR was reset and force-pushed manually.

@sttk sttk requested a review from Copilot July 26, 2025 22:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates the cliargs package by removing sub-packages and moving all program elements to the root package. The main motivation is to avoid naming conflicts with Go's standard errors package and simplify the import structure by eliminating the need to import multiple sub-packages.

Key changes:

  • Moved all error types from errors sub-package to root cliargs package
  • Moved validator functions from validators sub-package to root cliargs package
  • Updated all import statements and type references throughout the codebase

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
validators_test.go Updated package name and import path from validators sub-package to cliargs
validators.go Moved from validators sub-package to root, updated error type references
parse_test.go Removed errors import, updated error type references to cliargs namespace
parse.go Removed errors import, updated error type instantiation to cliargs namespace
parse-with_test.go Removed sub-package imports, updated error and validator type references
parse-with.go Removed errors import, updated error type instantiation to cliargs namespace
parse-for_test.go Removed errors import alias, updated error type references to cliargs namespace
parse-for.go Removed errors import, updated error type instantiation to cliargs namespace
example_errors_test.go Updated package name and import, changed error alias usage
errors_test.go Updated package name and import from errors sub-package to cliargs
errors.go Moved from errors sub-package to root, removed package comment

@sttk sttk merged commit 4e0868e into main Jul 26, 2025
12 checks passed
@sttk sttk deleted the move_program_elems_in_sub_packages_to_root branch July 26, 2025 22:56
sttk added a commit that referenced this pull request Jul 27, 2025
@sttk sttk changed the title update!: moved all program elements in sub packages to root ~~update!: moved all program elements in sub packages to root~~ Jul 27, 2025
@sttk sttk changed the title ~~update!: moved all program elements in sub packages to root~~ update!: moved all program elements in sub packages to root Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants