-
Notifications
You must be signed in to change notification settings - Fork 25
Add admin popup on Windows when running install-unity #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ewilh
wants to merge
36
commits into
sttz:windows
Choose a base branch
from
ewilh:windows
base: windows
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that after the admin pop-up, a separate shell window with admin privileges will open. When the code is finished running, the admin shell window will close immediately, thus preventing the user from seeing the output. A solution is to add a "Press any key to exit" on Windows only. Something like this:
|
…ework" option can be omitted
…rect to unity.com
- Updated across the board, including JDK and newly adding Android SDK Command Line Tools - NDK is now installed from a DMG but needs some additional processing: -- Added destination support to dmg packages, copies only app bundle content from dmg -- Made reanmeFrom/To generic instead of only supported for zip -- Support moving a directory in place of one of its parents (e.g. /path/to/source to /path/to)
…d of -R (now same as Hub is using)
…at "/Applications/Unity"
…er improvements - Reduces the amounts of requests and data loaded, can only load new releases instead of everything - Releases should appear quicker, in cases where Unity is slow to update their archive - Previously missing packages metadata (Documentation, Android components, language packs) is now provided by Unity - Legacy scraper and ini system can still be used for unpublished Unity releases - Platform / architecture is now split, added --arch option - Added --clear-cache option to force clearing the cache at start - Added --redownload option to force redownloading all files - Optimize detecting current architecture, RuntimeInformation.OSArchitecture now works correctly on .Net 7 - Optimize finding Unity installations by using native Plist parser - Improve handling of already downloaded files
- Check we're not running as X86 on a non-X86 system to avoid using the "Program Files (x86)" folder - Default to installing directly in "Program Files" and not using the Unity Hub install location (like on macOS) - Use "{ProrgamFiles}" variable in configuration to make settings more portable
…xe exists as expected path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
app.manifest
for admin privilege request. Running install-unity will now prompt user for admin credentials.The downside is that not all methods in install-unity require admin consent, but it will ask for it regardless.
I haven't changed anything from the default
app.manifest
except on line 19 with the code:<requestedExecutionLevel level="requireAdministrator" uiAccess="false" />
There might be more changes needed in the
app.manifest
before it's ready for production.I also added
RuntimeIdentifiers
so that I'm able to publish the app. I'm not quite sure how you're able to publish on Windows without this.I noticed that Unity was firstly installed on the path
Unity {major}.{minor}
, and I don't necessarily like that approach. Most Unity users (and especially those who use this tool) will install multiple different Unity versions on{major}.{minor}
. I recommend removing this both for Windows and Mac, but here I've only removed it for Windows.