Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Maker) Preventing revert: "Vat/dust" due to high fees #102

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

(Maker) Preventing revert: "Vat/dust" due to high fees #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6154732
Prevent revert: "Vat/dust"
xternet May 1, 2021
078d745
Preventing revert: "Vat/dust" due to high fees.
xternet May 1, 2021
05d13b2
Deleting unnecessary "await" keyword
xternet May 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions docs/maker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,8 @@ test("create a proxy on Maker", async () => {

### Opening A Vault

The example below will open a new vault, collateralize 1 ETH and take out 20 DAI debt
Note that the attempt to mint smaller DAI amounts can be reverted due to high gas fees.
The example below will open a new vault, collateralize 10 ETH and take out 10000 DAI debt.

```js
// ../tests/maker.test.ts#L39-L91
Expand Down Expand Up @@ -302,19 +303,19 @@ test("open Vault on Maker", async () => {
maker.ethAJoin.address,
maker.daiJoin.address,
ethers.utils.formatBytes32String(maker.ethA.symbol),
ethers.utils.parseUnits("20", erc20.dai.decimals),
ethers.utils.parseUnits("10000", erc20.dai.decimals),
]);

const ethBefore = await await wallet.getBalance();
const ethBefore = await wallet.getBalance();
const daiBefore = await daiContract.balanceOf(wallet.address);

// Open vault through proxy
await proxyContract.execute(maker.dssProxyActions.address, _data, {
gasLimit: 2500000,
value: ethers.utils.parseEther("1"),
value: ethers.utils.parseEther("10"),
});

const ethAfter = await await wallet.getBalance();
const ethAfter = await wallet.getBalance();
const daiAfter = await daiContract.balanceOf(wallet.address);

const ethSpent = parseFloat(fromWei(ethBefore.sub(ethAfter)));
Expand All @@ -327,7 +328,7 @@ test("open Vault on Maker", async () => {

## Example (Solidity)

Due to the way Maker has constructed its logic, if you would like to create a contract that does an action, e.g. open a vault, lock up 1 ETH and draw 20 DAI, you can't just call `DSSProxyAction`. You'll have to re-implement the logic into your contract itself.
Due to the way Maker has constructed its logic, if you would like to create a contract that does an action, e.g. open a vault, lock up 10 ETH and draw 10000 DAI, you can't just call `DSSProxyAction`. You'll have to re-implement the logic into your contract itself.

Fortunately, the primitives are well written in [DssProxyActions.sol](https://github.com/makerdao/dss-proxy-actions/blob/master/src/DssProxyActions.sol).

Expand Down Expand Up @@ -373,6 +374,17 @@ contract MyCustomVaultManager is DssProxyActionsBase {

```

To execute the contract, you'll need to perform the delegate-call via proxy, just like the JavaScript example of opening a vault. But this time, instead of using `legos.maker.dssProxyActions.abi` as the abi for interface encoding, you'll need to supply your contract's abi (in this example it's `MyCustomVaultManager`), and change the encoding function from `openLockETHAndDraw` to your newly defined function (in this example it's `myCustomOpenVaultFunction`).
After `MyCustomVaultManager` migration, DAI can be minted by calling filled with arguments `myCustomOpenVaultFunction`

Note that you don't need to redeploy a proxy registry / proxy contract to make it work with your new `MyCustomVaultManager` contract and can simply use your existing Maker proxy.
```js
// source: https://github.com/xternet/mint_dai/blob/master/scripts/mint_dai_via_contract.js

await MyCustomVaultManager.myCustomOpenVaultFunction(
legos.maker.dssCdpManager.address,
legos.maker.jug.address,
legos.maker.ethAJoin.address,
legos.maker.daiJoin.address,
ethers.utils.parseUnits("10000", legos.erc20.dai.decimals),
{ gasLimit: 2500000, value: ethers.utils.parseEther("10") },
)
```
4 changes: 2 additions & 2 deletions tests/maker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ describe("maker", () => {
maker.ethAJoin.address,
maker.daiJoin.address,
ethers.utils.formatBytes32String(maker.ethA.symbol),
ethers.utils.parseUnits("20", erc20.dai.decimals),
ethers.utils.parseUnits("10000", erc20.dai.decimals),
]);

const ethBefore = await await wallet.getBalance();
Expand All @@ -77,7 +77,7 @@ describe("maker", () => {
// Open vault through proxy
await proxyContract.execute(maker.dssProxyActions.address, _data, {
gasLimit: 2500000,
value: ethers.utils.parseEther("1"),
value: ethers.utils.parseEther("10"),
});

const ethAfter = await await wallet.getBalance();
Expand Down