Merge pull request #44 from styxlab/ghost-links

improve cms link rewrites

lib/ghost-normalize.ts

@@ -8,13 +8,14 @@ import { PostOrPage } from '@tryghost/content-api'
 import { Dimensions, imageDimensions } from '@lib/images'
 import { generateTableOfContents } from '@lib/toc'
 import { GhostPostOrPage, createNextProfileImagesFromAuthors } from './ghost'
+import { parse as urlParse, UrlWithStringQuery } from 'url'
 
 import { processEnv } from '@lib/processEnv'
 const { prism, toc, nextImages } = processEnv
 
 const rehype = Rehype().use({ settings: { fragment: true, space: `html`, emitParseErrors: false, verbose: false } })
 
-export const normalizePost = async (post: PostOrPage, cmsUrl: string | undefined, basePath?: string): Promise<GhostPostOrPage> => {
+export const normalizePost = async (post: PostOrPage, cmsUrl: UrlWithStringQuery | undefined, basePath?: string): Promise<GhostPostOrPage> => {
   if (!cmsUrl) throw Error('ghost-normalize.ts: cmsUrl expected.')
   const rewriteGhostLinks = withRewriteGhostLinks(cmsUrl, basePath)
 
@@ -47,11 +48,11 @@ export const normalizePost = async (post: PostOrPage, cmsUrl: string | undefined
  * Rewrite absolute Ghost CMS links to relative
  */
 
-const withRewriteGhostLinks = (cmsUrl: string, basePath = '/') => (htmlAst: Node) => {
+const withRewriteGhostLinks = (cmsUrl: UrlWithStringQuery, basePath = '/') => (htmlAst: Node) => {
   visit(htmlAst, { tagName: `a` }, (node: Node) => {
-    const href = (node.properties as HTMLAnchorElement).href
-    if (href?.startsWith(cmsUrl)) {
-      ;(node.properties as HTMLAnchorElement).href = href.replace(cmsUrl, basePath).replace('//', '/')
+    const href = urlParse((node.properties as HTMLAnchorElement).href)
+    if (href.protocol === cmsUrl.protocol && href.host === cmsUrl.host) {
+      ;(node.properties as HTMLAnchorElement).href = basePath + href.pathname?.substring(1)
     }
   })
 

lib/ghost.ts

@@ -1,3 +1,4 @@
+import { parse as urlParse, UrlWithStringQuery } from 'url'
 import GhostContentAPI, { Params, PostOrPage, SettingsResponse, Pagination, PostsOrPages, Tag, Author } from '@tryghost/content-api'
 import { normalizePost } from '@lib/ghost-normalize'
 import { Node } from 'unist'
@@ -200,7 +201,7 @@ export async function getPostBySlug(slug: string): Promise<GhostPostOrPage | nul
     if (!post) return null
 
     const { url } = await getAllSettings()
-    result = await normalizePost(post, url)
+    result = await normalizePost(post, (url && urlParse(url)) || undefined)
   } catch (error) {
     if (error.response?.status !== 404) throw new Error(error)
     return null
@@ -220,7 +221,7 @@ export async function getPageBySlug(slug: string): Promise<GhostPostOrPage | nul
     if (!page) return null
 
     const { url } = await getAllSettings()
-    result = await normalizePost(page, url)
+    result = await normalizePost(page, (url && urlParse(url)) || undefined)
   } catch (error) {
     if (error.response?.status !== 404) throw new Error(error)
     return null