-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JavaScript] Handle type argument in JSDoc documentation #2629
Open
rchl
wants to merge
8
commits into
sublimehq:master
Choose a base branch
from
rchl:feat/jsdoc-type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on May 12, 2023
-
[JavaScript] Handle type argument in JSDoc documentation
Enables parsing of types that can follow some block tags. The type is scoped with a single scope instead of trying to parse the type in a "correct" way (how typescript syntax does for types). This is for one due to the fact that I don't know how to do it "properly" but even more importantly because typing it properly would make the type more noisy visually. The only exception is that the dot is scoped as an accessor so that it triggers completions (especially useful when using LSP).
Configuration menu - View commit details
-
Copy full SHA for f500506 - Browse repository at this point
Copy the full SHA f500506View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89f098d - Browse repository at this point
Copy the full SHA 89f098dView commit details
Commits on May 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9fe2f18 - Browse repository at this point
Copy the full SHA 9fe2f18View commit details
Commits on May 14, 2023
-
Co-authored-by: Keith Hall <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3238a1d - Browse repository at this point
Copy the full SHA 3238a1dView commit details -
Co-authored-by: Keith Hall <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 83a86a8 - Browse repository at this point
Copy the full SHA 83a86a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 677a739 - Browse repository at this point
Copy the full SHA 677a739View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84884ed - Browse repository at this point
Copy the full SHA 84884edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 071f920 - Browse repository at this point
Copy the full SHA 071f920View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.