Skip to content

Route legacy OpenAI completion builds through prefixed tags - #9507

Open
yaroslavyaroslav wants to merge 6 commits into
sublimehq:masterfrom
yaroslavyaroslav:chore/openai-python-3.14-releases
Open

Route legacy OpenAI completion builds through prefixed tags#9507
yaroslavyaroslav wants to merge 6 commits into
sublimehq:masterfrom
yaroslavyaroslav:chore/openai-python-3.14-releases

Conversation

@yaroslavyaroslav

@yaroslavyaroslav yaroslavyaroslav commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

What changed

Split OpenAI completion releases by Sublime Text's plugin-host runtime:

  • builds 4050–4204 use tags prefixed with py38-
  • builds 4205+ use regular, unprefixed release tags

The legacy py38-6.1.0 tag points to the existing 6.1.0 release commit (f7ed5211bad22942ed13162e87ac07ede37f5d95).

Why

Sublime Text 4205 replaces the Python 3.8 plugin host with Python 3.14. Prefixed tags keep the legacy package line fixed while allowing new releases to retain the normal 6.2.0, 6.3.0, … tag format.

The release sources do not overlap:

  • 4050–4204: py38-* tags
  • 4205+: unprefixed tags

Validation

  • uv run pytest -q: 33 passed
  • uv run -m tools.format_package_control_channel repository/o.json --check
  • parsed repository/o.json with python3 -m json.tool
  • verified Package Control's current prefix selector maps py38-6.1.0 to version 6.1.0 and excludes prefixed tags from the unprefixed source

@yaroslavyaroslav yaroslavyaroslav changed the title Split OpenAI completion Python runtime releases Add OpenAI completion Python 3.14 release source Aug 4, 2026
@yaroslavyaroslav
yaroslavyaroslav marked this pull request as ready for review August 4, 2026 14:58
@rchl

rchl commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

I don't understand why do it this way.
Create a branch for <3.14 builds and keep unprefixed tags for latest builds.
IMO simplifies everything.

@yaroslavyaroslav yaroslavyaroslav changed the title Add OpenAI completion Python 3.14 release source Route legacy OpenAI completion builds through Python 3.8 branch Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR changes OpenAI completion.

Review for OpenAI completion develop-fb34836-2026.08.04.15.26.53

Unhandled exception in 'check' routine
Traceback (most recent call last):
File "/home/runner/work/_actions/kaste/st_package_reviewer/v1/st_package_reviewer/check/init.py", line 40, in perform_check
self.check()
~~~~~~~~~~^^
File "/home/runner/work/_actions/kaste/st_package_reviewer/v1/st_package_reviewer/check/file/check_repo_tags.py", line 153, in check
tip_status = self._collect_tip_status_remote(self.repo, latest_semver_tag)
File "/home/runner/work/_actions/kaste/st_package_reviewer/v1/st_package_reviewer/check/file/check_repo_tags.py", line 238, in _collect_tip_status_remote
with tempfile.TemporaryDirectory(prefix="pkg-rev-git-") as tempdir:
~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/tempfile.py", line 971, in exit
self.cleanup()
~~~~~~~~~~~~^^
File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/tempfile.py", line 975, in cleanup
self._rmtree(self.name, ignore_errors=self._ignore_cleanup_errors)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/tempfile.py", line 955, in _rmtree
_shutil.rmtree(name, onexc=onexc)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/shutil.py", line 852, in rmtree
_rmtree_impl(path, dir_fd, onexc)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/shutil.py", line 721, in _rmtree_safe_fd
_rmtree_safe_fd_step(stack, onexc)
~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/shutil.py", line 802, in _rmtree_safe_fd_step
onexc(func, path, err)
~~~~~^^^^^^^^^^^^^^^^^
File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/shutil.py", line 753, in _rmtree_safe_fd_step
os.rmdir(name, dir_fd=dirfd)
~~~~~~~~^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 39] Directory not empty: '/tmp/pkg-rev-git-nkwbz4hq/.git/objects'

  • Repository is at https://github.com/yaroslavyaroslav/OpenAI-sublime-text
    1 failure:
  • Unhandled exception in 'check' routine
    Exception: [Errno 39] Directory not empty: '/tmp/pkg-rev-git-nkwbz4hq/.git/objects'
    Traceback (most recent call last):
    File "/home/runner/work/_actions/kaste/st_package_reviewer/v1/st_package_reviewer/check/init.py", line 40, in perform_check
    self.check()
    File "/home/runner/work/_actions/kaste/st_package_reviewer/v1/st_package_reviewer/check/file/check_repo_tags.py", line 153, in check
    tip_status = self._collect_tip_status_remote(self.repo, latest_semver_tag)
    File "/home/runner/work/_actions/kaste/st_package_reviewer/v1/st_package_reviewer/check/file/check_repo_tags.py", line 238, in _collect_tip_status_remote
    with tempfile.TemporaryDirectory(prefix="pkg-rev-git-") as tempdir:
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/tempfile.py", line 971, in __exit__
    self.cleanup()
    ~~~~~~~~~~~~^^
    File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/tempfile.py", line 975, in cleanup
    self._rmtree(self.name, ignore_errors=self._ignore_cleanup_errors)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/tempfile.py", line 955, in _rmtree
    _shutil.rmtree(name, onexc=onexc)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/shutil.py", line 852, in rmtree
    _rmtree_impl(path, dir_fd, onexc)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/shutil.py", line 721, in _rmtree_safe_fd
    _rmtree_safe_fd_step(stack, onexc)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
    File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/shutil.py", line 802, in _rmtree_safe_fd_step
    onexc(func, path, err)
    ~~~~~^^^^^^^^^^^^^^^^^
    File "/home/runner/work/_temp/uv-python-dir/cpython-3.14.6-linux-x86_64-gnu/lib/python3.14/shutil.py", line 753, in _rmtree_safe_fd_step
    os.rmdir(name, dir_fd=dirfd)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^
    

OSError: [Errno 39] Directory not empty: '/tmp/pkg-rev-git-nkwbz4hq/.git/objects'

4 warnings:

  • Found multiple command prefixes: erase, openai, replace, select, stop, text, toggle. Consider using one single prefix so as to not clutter the command namespace.
  • Command palette entry for editing settings should start with 'Preferences: OpenAI completion'. Found: Preferences: OpenAI Settings
    File: Default.sublime-commands
  • Command palette entry for editing key bindings should start with 'Preferences: OpenAI completion'. Found: Preferences: OpenAI Key Bindings
    File: Default.sublime-commands
  • You define 'openAI.sublime-settings' but 'openAI' is neither your package name nor the name of a syntax you ship.
    File: openAI.sublime-settings

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR changes OpenAI completion.

Review for OpenAI completion develop-fb34836-2026.08.04.15.26.53

No failures

4 warnings:

  • Found multiple command prefixes: erase, openai, replace, select, stop, text, toggle. Consider using one single prefix so as to not clutter the command namespace.
  • Command palette entry for editing settings should start with 'Preferences: OpenAI completion'. Found: Preferences: OpenAI Settings
    File: Default.sublime-commands
  • Command palette entry for editing key bindings should start with 'Preferences: OpenAI completion'. Found: Preferences: OpenAI Key Bindings
    File: Default.sublime-commands
  • You define 'openAI.sublime-settings' but 'openAI' is neither your package name nor the name of a syntax you ship.
    File: openAI.sublime-settings

@rchl

rchl commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

That's not what I meant. Use prefixed tags for older builds. I don't think the use of branches is recommended anymore.

EDIT: Sorry, I actually meant prefixed tags and not a dedicated branch in my previous comment.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR changes OpenAI completion.

Review for OpenAI completion develop-fb34836-2026.08.04.15.26.53

No failures

4 warnings:

  • Found multiple command prefixes: erase, openai, replace, select, stop, text, toggle. Consider using one single prefix so as to not clutter the command namespace.
  • Command palette entry for editing settings should start with 'Preferences: OpenAI completion'. Found: Preferences: OpenAI Settings
    File: Default.sublime-commands
  • Command palette entry for editing key bindings should start with 'Preferences: OpenAI completion'. Found: Preferences: OpenAI Key Bindings
    File: Default.sublime-commands
  • You define 'openAI.sublime-settings' but 'openAI' is neither your package name nor the name of a syntax you ship.
    File: openAI.sublime-settings

@yaroslavyaroslav yaroslavyaroslav changed the title Route legacy OpenAI completion builds through Python 3.8 branch Route legacy OpenAI completion builds through prefixed tags Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants