Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for arithmetic decimal function "sqrt" and "factorial" #92

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add test cases for arithmetic decimal function "sqrt" and "factorial" #92

merged 1 commit into from
Aug 23, 2024

Conversation

anshuldata
Copy link
Contributor

  • duckdb doesn't support factorial on decimal type so it is not supported in duckdb dialect
  • Currently I am focusing on Snowflake and Duckdb dialect so skipped other dialects for now.
  • Updated Precision based on Substrait Spec (here) which is as follows:
    Sqrt:
    Input: DECIMAL<P, S> ==> Result fp64
    Factorial:
    Input: DECIMAL<P, S> ==> Result DECIMAL<38,0>

@anshuldata anshuldata mentioned this pull request Aug 22, 2024
Closed
@anshuldata
Copy link
Contributor Author

For workflow errors, raised this PR

@anshuldata
Copy link
Contributor Author

rebased it

@anshuldata
Copy link
Contributor Author

rebased it to resolve merge conflict
CC: @richtia

@richtia richtia merged commit 573adcb into substrait-io:main Aug 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtia richtia richtia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshuldata @richtia